test(causalConsistency): adding an example test for causal consistency #1651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbroadst
suggested changes
Jan 22, 2018
daprahamian
force-pushed
the
NODE-1262
branch
2 times, most recently
from
52cbc30 to
d38294b
Compare
daprahamian
force-pushed
the
NODE-1262
branch
from
d38294b to
5247e86
Compare
|
This test is now in |
jlord
reviewed
Jan 30, 2018
| @@ -1,6 +1,7 @@ | |||
| 'use strict'; | |||
|
|
|||
| var assert = require('assert'); | |||
| const expect = require('chai').expect; | |||
There was a problem hiding this comment.
Should the rest of the file be updated to use expect or should this test use the same format as the rest of the tests?
There was a problem hiding this comment.
I think that would be a bit much for just this PR, would make it harder to read. Agreed that we should eventually do this in the future though.
mbroadst
approved these changes
Jan 30, 2018
jlord
approved these changes
Jan 30, 2018
This was referenced Mar 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes NODE-1262
NOTE: the version filter means the test isn't currently being run :(